fix: avoid call to method that recalibrates already-calibrated dsc2#1153
Merged
baltzell merged 1 commit intodevelopmentfrom Mar 21, 2026
Merged
fix: avoid call to method that recalibrates already-calibrated dsc2#1153baltzell merged 1 commit intodevelopmentfrom
baltzell merged 1 commit intodevelopmentfrom
Conversation
baltzell
approved these changes
Mar 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The unnecessary recalibration was introducing a bias because the time from the gated clock was being used in the offset correction of the ungated fcup, and further multiplied by the lifetime, in the offset correction of the gated fcup